fix(router): call OnRouterConfigReload before config hot-reload

[arutkowski00]

Problem

Supervisor restarts call OnRouterConfigReload() to extract slow-plan cache entries before replacing the graph server. CDN and manifest hot-reload paths skipped this hook, leaving stale cache references on the old graphMux.

Fix

Call OnRouterConfigReload() at the start of newServer().

Test plan

• go test ./router/core/...

Part of config hot-reload memory leak investigation (monday.com #3221).

[coderabbitai]

Warning

Review limit reached

@arutkowski00, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 945f1823-c2ad-4bad-82f8-1af04ac0da55

📥 Commits

Reviewing files that changed from the base of the PR and between 7b40f14 and c1c691a.

📒 Files selected for processing (1)

• router/core/router.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[dkorittki]

Good catch! Unfortunately the way it is right now it adds a regression on the supervisor Reload path. The supervisor already calls OnRouterConfigReload() on the old router before shutting it down (supervisor.go:162). The new router's newServer() call will now hit OnRouterConfigReload() a second time with the map already in snapshot form. After the first call the values are already []*nodev1.Operation, so the second call's type assertion fails for every entry, nothing gets added to fallbackMap and queriesForFeatureFlag is overwritten with an empty map.

A quick fix would be to modify extractQueriesAndOverridePlanCache to preserve entries of type []*nodev1.Operation but I need to check if there are better ways of doing it. Will come back to this.