Skip to content

Conversation

@SkArchon
Copy link
Contributor

@SkArchon SkArchon commented Nov 19, 2025

Summary by CodeRabbit

  • Chores
    • Updated installation script source to reference a stable version tag instead of a specific commit reference.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Walkthrough

The installation script URL for the toolchain in the plugin router command was updated from a commit-specific reference to a version tag reference (refs/tags/[email protected]). No logic or control flow changes were made.

Changes

Cohort / File(s) Summary
Toolchain configuration
cli/src/commands/router/commands/plugin/toolchain.ts
Updated installScriptUrl from commit-specific URL to tag-based URL (refs/tags/[email protected])

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Single file change with straightforward configuration update
  • No logic or control flow modifications
  • Verify the new tag reference is correct and accessible

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly relates to the main change: updating the installScriptUrl from a commit-specific URL to a tag-based URL in the toolchain configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93843ff and 4f28346.

📒 Files selected for processing (1)
  • cli/src/commands/router/commands/plugin/toolchain.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
cli/src/commands/router/commands/plugin/toolchain.ts (1)

53-54: installScriptUrl now correctly targets tagged install script

The new installScriptUrl resolves to a valid install-proto-tools.sh at [email protected], exposing the expected env vars used by this file (GO_VERSION, PROTOC_VERSION, PROTOC_GEN_GO_VERSION, PROTOC_GEN_GO_GRPC_VERSION, BUN_VERSION, NODE_VERSION, LANGUAGE, INSTALL_DIR, PRINT_INSTRUCTIONS, INSTALL_COMMON_TOOLS). The curl invocation in installTools remains correct, and version/env handling stays unchanged.

Only minor note: pinning to a Git tag (refs/tags/[email protected]) is slightly less immutable than a commit SHA but is typically acceptable and may better match your release workflow.


Comment @coderabbitai help to get the list of available commands and usage tips.

@SkArchon SkArchon merged commit dde0ec0 into main Nov 19, 2025
26 checks passed
@SkArchon SkArchon deleted the milinda/update-url-script branch November 19, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants