IOS: Fixed #139: Added nullability attributes to PA2ClientSslValidati…

…onStrategy
wultra · Sep 4, 2018 · 31b8d74 · 31b8d74
1 parent a4d8483
commit 31b8d74
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/proj-xcode/Classes/networking/ssl/PA2ClientSslNoValidationStrategy.m b/proj-xcode/Classes/networking/ssl/PA2ClientSslNoValidationStrategy.m
@@ -19,15 +19,14 @@
 
 @implementation PA2ClientSslNoValidationStrategy
 
-- (void)validateSslForSession:(NSURLSession *)session
-					challenge:(NSURLAuthenticationChallenge *)challenge
-			completionHandler:(void (^)(NSURLSessionAuthChallengeDisposition, NSURLCredential * _Nullable))completionHandler {
-	
+- (void) validateSslForSession:(nonnull NSURLSession *)session
+					 challenge:(nonnull NSURLAuthenticationChallenge *)challenge
+			 completionHandler:(void (^ _Nonnull)(NSURLSessionAuthChallengeDisposition, NSURLCredential * _Nullable))completionHandler
+{
 	// Allow any SSL certificate
-
 	PA2CriticalWarning(@"SSL validation is disabled. This code must not be present in production!");
 	NSURLCredential *credential = [NSURLCredential credentialForTrust:challenge.protectionSpace.serverTrust];
-	completionHandler(NSURLSessionAuthChallengeUseCredential,credential);
+	completionHandler(NSURLSessionAuthChallengeUseCredential, credential);
 }
 
 @end
diff --git a/proj-xcode/Classes/networking/ssl/PA2ClientSslValidationStrategy.h b/proj-xcode/Classes/networking/ssl/PA2ClientSslValidationStrategy.h
@@ -24,8 +24,8 @@
  
  The implementation must call `completionHandler` with an appropriate result of the verification.
  */
-- (void) validateSslForSession:(NSURLSession *)session
-					 challenge:(NSURLAuthenticationChallenge *)challenge
-			 completionHandler:(void (^)(NSURLSessionAuthChallengeDisposition, NSURLCredential *))completionHandler;
+- (void) validateSslForSession:(nonnull NSURLSession *)session
+					 challenge:(nonnull NSURLAuthenticationChallenge *)challenge
+			 completionHandler:(void (^ _Nonnull)(NSURLSessionAuthChallengeDisposition, NSURLCredential * _Nullable))completionHandler;
 
 @end