Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inbox notification to parser #158

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add inbox notification to parser #158

merged 2 commits into from
Jun 20, 2024

Conversation

Hopsaheysa
Copy link
Member

Fixes: #157

kober32
kober32 requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks OK.

Add this change to the "Changelog" file

  • add a new future TBA version to the changelog
  • add this feature to this version

@Hopsaheysa Hopsaheysa requested a review from kober32 June 20, 2024 14:35
kober32
kober32 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hopsaheysa Hopsaheysa merged commit cca38ed into develop Jun 20, 2024
4 checks passed
@Hopsaheysa Hopsaheysa deleted the issues/157-inbox-notif-parsing branch June 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Inbox message parsing to WMTPushParser
2 participants
@Hopsaheysa @kober32