Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAC with claim #132

Merged
merged 19 commits into from
Jan 9, 2024
Merged

PAC with claim #132

merged 19 commits into from
Jan 9, 2024

Conversation

Hopsaheysa
Copy link
Member

updated and renamed TOTPUtils parser to PACUtils #125

implemented #124
OperationDetail endpoint /api/auth/token/app/operation/detail
OperationClaim endpoint /api/auth/token/app/operation/detail/claim

…claim function. Rename TOTPParser for PACParser
…r deeplink, also fix and amend tests

# Conflicts:
#	WultraMobileTokenSDK/Operations/Utils/WMTTOTPUtils.swift
#	WultraMobileTokenSDKTests/TOTPParserTests.swift
Package.resolved Outdated Show resolved Hide resolved
@kober32
Copy link
Member

kober32 commented Nov 28, 2023

2 things:

we should add the PACUtils to the documentation (to the section https://github.com/wultra/mtoken-sdk-ios/blob/develop/docs/Using-Operations-Service.md#totp-wmtproximitycheck)
create a new pull request to releases/1.7.x branch with just WMTPACUtils changes so we can support it with the old 1.4.0 server.

@Hopsaheysa Hopsaheysa marked this pull request as ready for review December 8, 2023 11:15
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is OK, but the docs need some changes.

docs/Using-Operations-Service.md Outdated Show resolved Hide resolved
docs/Using-Operations-Service.md Outdated Show resolved Hide resolved
docs/Using-Operations-Service.md Show resolved Hide resolved
docs/Using-Operations-Service.md Outdated Show resolved Hide resolved
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hopsaheysa Hopsaheysa merged commit 6a5942a into develop Jan 9, 2024
4 checks passed
@Hopsaheysa Hopsaheysa deleted the feature/124-pac-with-claim branch January 9, 2024 13:26
Hopsaheysa added a commit that referenced this pull request Jul 31, 2024
* Implement new Operation Endpoint Claim and extend WMTOperations with claim function. Rename TOTPParser for PACParser

* #125: update parser so it is able to parse deeplink and also JWT in QR code

* Implement Detail endpoint and getDetail method to OperationsImpl

* Add docs for PACUtils

* Remove WMTPACUtils Keys from docs and add description of topt format in JWT/query

* Remove unneccesary spaces from doc

* Format docs

* Improved PAC Utils

# Conflicts:
#	WultraMobileTokenSDKTests/TOTPParserTests.swift

* Remove `Package.resolved`

* Fix endpoints to be signed with token

* Update docs

* Implement detail and claim integration tests

* Rename WMTClaim file

* Improve claim integration test

* Improve docs

* Fix claim docs

---------

Co-authored-by: Jan Kobersky <[email protected]>
kober32 pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants