Added minimum time interval and default value to operation polling #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kober32
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Works OK, just 1 change pls, and update the test:
- set the default also for
delayStart - in the
testOperationPollingremove thestartPollingOperationsparameters - they're set for 1s anyway, which no longer works, set thef (loadingCount == 4)condition only to 3 to lower the time for the test and raise theAssert.assertNull(future.get(20, TimeUnit.SECONDS))assert to 30 seconds to avoid possible network/server delays (now the test takes ~10 seconds minimum instead of ~3 seconds.
library/src/main/java/com/wultra/android/mtokensdk/operation/IOperationsService.kt
Outdated
Show resolved
Hide resolved
kober32
reviewed
Mar 18, 2024
library/src/main/java/com/wultra/android/mtokensdk/operation/IOperationsService.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141