Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed currentServerDate calculation to use powerAuthSDK timeService instead #139

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Removed currentServerDate calculation to use powerAuthSDK timeService instead #139

merged 4 commits into from
Mar 12, 2024

Conversation

Hopsaheysa
Copy link
Member

Fixes: #103

@Hopsaheysa Hopsaheysa requested a review from kober32 March 6, 2024 09:50
kober32
kober32 requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is OK, but could you create a migration guide? 1.9.x to 1.10.x and put it in the docs? The same goes for changelog - add new version (1.10.0 without specific date) and add this change to it.

@Hopsaheysa Hopsaheysa requested a review from kober32 March 8, 2024 10:47
kober32
kober32 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@Hopsaheysa Hopsaheysa merged commit 616b51a into develop Mar 12, 2024
4 checks passed
@Hopsaheysa Hopsaheysa deleted the issues/103-time-synchronization branch March 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use time synchronization from PA SDK instead of time from operations endpoint
2 participants
@Hopsaheysa @kober32