This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Clear for dialog fields #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 10, 2019 13:59
Fix DefaultSelect to enable BB the configuration of the Content Fragment component
Add ContentFragmentPathBrowser dialog field
Shaihuludus
suggested changes
Oct 22, 2019
| @@ -49,4 +50,9 @@ | |||
| default String getLabel() { | |||
| return null; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Better solution would be default here. Thanks to this it wouldn't required empty methods and would not break any API
There was a problem hiding this comment.
Also, document the new behaviour please :)
There was a problem hiding this comment.
Shaihuludus
approved these changes
Oct 22, 2019
| @@ -96,6 +96,7 @@ Properties: | |||
| - label - select dialog field with this label. If there is no label the fields will be selected in order. | |||
| - type - type of dialog field. All available OOB fields are displayed in section below | |||
| - value - what value should be set | |||
| - clear - true/false, currently viable only for Multifields, you decide if the field's state should be set to a blank before entering the new value. This translates to deleting all existing items in a Multifield before adding any new ones. | |||
mkrzyzanowski
approved these changes
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the option to decide whether a dialog field should be cleared or not before adding new values to it. Currently only Multifield has the clear() method implemented, others are empty. More will be added later when required during our work on testing core components.
Part of #373
Used by wttech/bobcat-aem-tests#16
Motivation and Context
Types of changes
Checklist: