This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Button core component tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaczymuczy
suggested changes
Oct 14, 2019
mkrzyzanowski
approved these changes
Oct 14, 2019
| @FindBy(css = ".cmp-button__icon") | ||
| private WebElement icon; | ||
|
|
||
| private static final String ARIA_LABEL = "aria-label"; |
There was a problem hiding this comment.
Nitpicking :). Order within a class by convention:
- constants
- fields
- methods
General:
- public
- package-private
- private
kaczymuczy
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button core component tests for wttech/bobcat#373.
This component is currently not available under We Retail. Installation of test components example package is required to run these tests (available here). Test page is created under /content/core-components-examples/library/.