Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lunarphase with keyboard controls, add custom keyboard snippets #169

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

doctorfree
Copy link
Contributor

The lunarphase module has been updated with keyboard controls to view the next or previous day/week lunar phase, open a url in a browser, and enable/disable widget display. These changes have been submitted in a wtf pull request.

The documentation for these changes are included in this pull request.

Note that this pull request includes some new keyboard snippets. The keyboard controls in lunarphase want to use KeyUp, KeyDown, and CtrlD but these are dedicated to other functions and the help message cannot be customized. To provide customized messages for these keys I added new keyboard snippets. Also, only lower case letters were available but lunarphase enables 'N' and 'P' keys to display next week and previous week. So I added keyboard snippets for 'N' and 'P'.

If these new keyboard snippets are not suitable I can easily modify lunarphase to accommodate your preference.

Note also that the todo module seems to be looking for ctrlf.md when it should be ctrlF.md. This causes mkdocs to throw a non-fatal exception. A fix for that is not included in this pull request.

@doctorfree
Copy link
Contributor Author

I am cancelling this pull request while debugging an issue in the latest lunarphase module

@doctorfree doctorfree closed this Dec 28, 2022
@doctorfree
Copy link
Contributor Author

I've reopened the wtf pull request for the lunarphase module and am therefore re-opening this pull request for the documentation associated with that module.

@doctorfree doctorfree reopened this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant