Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Scenarios to improve legibility and workflow management. #315

Merged
merged 20 commits into from
Apr 26, 2023
Merged

Refactor Scenarios to improve legibility and workflow management. #315

merged 20 commits into from
Apr 26, 2023

Commits on Mar 7, 2023

  1. Implements scenario changes from #277 

    Changes how scenarios works per description in #277 and updates relevant documentation about API changes.

Also:
- various efficiencies and consistency fixes
    @e-lo
    e-lo committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    f8379c3 View commit details
    Browse the repository at this point in the history

  2. Update example notebooks for tiny API changes

    @e-lo
    e-lo committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d1846a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Update to use a deque object 

    So you aren't iterating over a changing list
    @e-lo
    e-lo committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    48c708d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Merge branch 'develop' of https://github.com/wsp-sag/network_wrangler … 

    …into change_project_apply_handling
    @e-lo
    e-lo committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    65fb4f4 View commit details
    Browse the repository at this point in the history

  2. Merge updates from develop. Black.

    @e-lo
    e-lo committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    1dc8903 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge remote-tracking branch 'origin/develop' into change_project_app… 

    …ly_handling
    @e-lo
    e-lo committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d4efbcb View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into change_project_app… 

    …ly_handling
    @e-lo
    e-lo committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f08abb7 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Merge remote-tracking branch 'origin/develop' into change_project_app… 

    …ly_handling
    @e-lo
    e-lo committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    55b6982 View commit details
    Browse the repository at this point in the history

  2. add a little more documentation

    @e-lo
    e-lo committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e459a16 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Update notebook/Scenario Building Example.ipynb 

    Co-authored-by: Sijia Wang <[email protected]>
    @e-lo @i-am-sijia
    e-lo and i-am-sijia committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    bfa3f17 View commit details
    Browse the repository at this point in the history

  2. Fix default project_card_list to be [] not None 

    Also:
- Better document Scenario.__init__ arguments
- Require minimum variables in base_scenario: applied_projects and conflicts
    @e-lo
    e-lo committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    48ad42b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'change_project_apply_handling' of https://github.com/ws… 

    …p-sag/network_wrangler into change_project_apply_handling
    @e-lo
    e-lo committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    297c675 View commit details
    Browse the repository at this point in the history

  4. Address mapping type --> list and set type needed for isdisjoint

    @e-lo
    e-lo committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f0dbbd7 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Varia fixes from Sijia! (thx!) 

    - is_disjoint is actually isdisjoint (doh!) and performed on a set object
- mapping objects converted to lists (doh!)
- `planned_proejects` should actually be `_planned _projects`
- _queued_projects should be truthiness-checked, not ever none
    @e-lo
    e-lo committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    cff89fd View commit details
    Browse the repository at this point in the history

  2. Remove universal lower() / fixed validate method ref

    @e-lo
    e-lo committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    e35d844 View commit details
    Browse the repository at this point in the history

  3. scenario tests now use fixtures + are consistently formatted 

    also:
- fixed a lot of API usage
- added specific Exception types for better error catching in testing
- black
    @e-lo
    e-lo committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f081e52 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. import copy

    @e-lo
    e-lo committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f4d9b3a View commit details
    Browse the repository at this point in the history

  2. fix import

    @e-lo
    e-lo committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    b6f0747 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Add project card path to the debug statement

    @lmz
    lmz committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    086d30a View commit details
    Browse the repository at this point in the history

  2. The suffix includes the period; drop the period for this check

    @lmz
    lmz committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    912a254 View commit details
    Browse the repository at this point in the history