Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs to roadway #296

Closed
wants to merge 3 commits into from
Closed

Add kwargs to roadway #296

wants to merge 3 commits into from

Conversation

e-lo
Copy link
Collaborator

@e-lo e-lo commented Apr 22, 2022

Problem

As a user, I need to be able to specify various parameters for my RoadwayNetwork such as CRS and foreign IDs

Solution

Re-orients previous class-Level hardcoded-variables to module-level defaults which can be set upon RoadwayNetwork class instantiation.

Fixes #290

Considerations for reviewers:

  • Should we do this for Transit as well - separate issue?
  • Are the "defaults" currently appropriate?

- re-orients previous class-Level hardcoded-variables to module-level defaults which can be set upon RoadwayNetwork class instantiation.
@e-lo e-lo added the enhancement New feature or request label Apr 22, 2022
@e-lo e-lo self-assigned this Apr 22, 2022
Copy link
Member

@DavidOry DavidOry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of cosmetic changes here, e.g., link_file to link_filename. Can we separate these into a separate PR?

@e-lo e-lo marked this pull request as draft June 26, 2023 17:21
@e-lo
Copy link
Collaborator Author

e-lo commented Aug 21, 2024

Closing this as we have aligned over a more strict model in selection-refactor branch.

@e-lo e-lo closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants