Generalize necessary changes for MTC to work for MetCouncil and other agencies into the future #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Scalar values were different
2. MTC needed additional variables copied to managed lanes
3. Different foreign key for shapes
4. Scenario initiation from a Scenario instance OR a dictionary representing one
Co-authored-by: David Ory <[email protected]>
- moved parameters from client.py to modules - added params to class instances - parameterized methods for non instance-level vars TODO: update all notebooks and usage.
Fixes #229 by making methods parameterizable and storing most client settings in RoadwayNetwork and TransitNetwork instance-level with good defaults rather than class-level variables. Also: - Added notebook testing - Some other clean up
- fixed typo bugs
- Allow new columns to be added wholesale - Also fixes #257
- output links, nodes, shapes for managed lane network - externalize `has_managed_lanes()`
+ some PEP8
|
Hello - is it possible to prioritize this PR? I'm concerned that the distance between |
|
Hi again, @DavidOry , @i-am-sijia and @e-lo -- Just pinging on this again; what's the plan/timeline? Thank you! |
Yes. Discussed this morning with @e-lo. What's your best guess at a timeline @e-lo? |
Update Travis from using "travis" to "CI"
- exclude validation status on write by default. - add an explicit write-order by default
|
CLosing this as having been superceeded by work in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #229