Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Allow kwargs for roadway network creation #290

Closed
2 of 4 tasks
e-lo opened this issue Apr 19, 2022 · 1 comment
Closed
2 of 4 tasks

[FEATURE] Allow kwargs for roadway network creation #290

e-lo opened this issue Apr 19, 2022 · 1 comment
Assignees
@e-lo
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@e-lo
Copy link
Collaborator

e-lo commented Apr 19, 2022 •
edited
Loading

User Story

As a user who might use a different field as a foreign ID, I'd like to add kwargs to roadway network creation to override any defaults such as shape_id vs id for SHAPE_UNIQUE_ID.

Status

  • Defined
  • Planned
  • Implemented
  • Tested

Priority

Medium

Level of Effort

Low
@e-lo e-lo added the enhancement New feature or request label Apr 19, 2022
@e-lo e-lo added this to the v1.0 milestone Apr 19, 2022
@e-lo e-lo self-assigned this Apr 19, 2022
@e-lo e-lo mentioned this issue Apr 22, 2022
Closed
2 tasks
@e-lo e-lo mentioned this issue Mar 2, 2023
Closed
@e-lo e-lo linked a pull request Mar 3, 2023 that will close this issue
Allow kwargs in network creation to override Class-level variables for Roadway and Transit #312
Closed
@e-lo
Copy link
Collaborator Author

e-lo commented Jul 17, 2024

WIth new data model implementation we are being more rigorous in what can go in/out of wrangler. That said, we did implement a small work-around that will rename id to shape_id in the roadway shapes.txt. This will NOT make it write out that way though!

@e-lo e-lo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-lo e-lo

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
1 participant
@e-lo