Add ftp improvements by niveathika · Pull Request #1423 · wso2/vscode-extensions

niveathika · 2026-02-12T07:42:55Z

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

UI Component Development

Specify the reason if following are not followed.

Added reusable UI components to the ui-toolkit. Follow the intructions when adding the componenent.
Use ui-toolkit components wherever possible. Run npm run storybook from the root directory to view current components.
Matches with the native VSCode look and feel.

Manage Icons

Specify the reason if following are not followed.

Added Icons to the font-wso2-vscode. Follow the instructions.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information
Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

coderabbitai · 2026-02-12T07:43:05Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR enhances the FTP service functionality by adding support for the onError handler, improving post-processing actions with success/error configurations, and refining the UI for better user experience.

Changes:

Added onError handler support alongside existing onCreate and onDelete handlers
Implemented post-processing actions (move/delete) with separate configurations for success and error scenarios
Enhanced UI with info banners, collapsible advanced configs, and improved parameter editing
Updated FTP service display to show monitoring paths in service/listener titles

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
workspaces/ballerina/type-editor/src/TypeEditor/ContextBasedTypeEditor/ContextTypeEditor.tsx	Added `note` prop to display informational messages in type editor
workspaces/ballerina/type-editor/src/TypeEditor/ContextBasedTypeEditor/ContextTypeCreator.tsx	Implemented info banner component to display the note prop
workspaces/ballerina/type-editor/src/TypeEditor/ContextBasedTypeEditor/BrowseTypesTab.tsx	Added info banner support in browse types tab
workspaces/ballerina/ballerina-visualizer/src/views/BI/TypeEditor/index.tsx	Propagated `note` prop through type editor components
workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/index.tsx	Added `onError` handler support and implemented FTP service title display with path
workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/ServiceConfigureView.tsx	Enhanced listener configuration to differentiate attached listeners and show minimal config
workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/Forms/FTPForm/index.tsx	Major refactor: added post-processing actions, parameter name derivation, and reorganized UI with collapsible sections
workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/Forms/FTPForm/Parameters/Parameters.tsx	Enhanced parameter component with inline editing capabilities
workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/Forms/FTPForm/Parameters/ParamEditor.tsx	New component for inline parameter editing with name and type fields
workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/Forms/FTPForm/FTPConfigForm.tsx	Added `onError` event to available handler events
workspaces/ballerina/ballerina-visualizer/src/components/EntryPointTypeCreator/index.tsx	Added `note` prop support to entry point type creator
workspaces/ballerina/ballerina-extension/src/utils/project-artifacts.ts	Updated service display name to include FTP path/accessor information

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T07:48:02Z

workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/Forms/FTPForm/index.tsx

+ * Converts a PascalCase or camelCase type name to a camelCase parameter name.
+ * For CSV format, pluralizes the name since it represents an array of rows.
+ */
+const typeNameToParamName = (typeName: string, pluralize: boolean = false): string => {


The function name typeNameToParamName is ambiguous. Consider renaming to convertTypeNameToParameterName to better convey that it performs a conversion with pluralization rules.

Suggested change

const typeNameToParamName = (typeName: string, pluralize: boolean = false): string => {

const convertTypeNameToParameterName = (typeName: string, pluralize: boolean = false): string => {

Copilot · 2026-02-12T07:48:02Z

...na/ballerina-visualizer/src/views/BI/ServiceDesigner/Forms/FTPForm/Parameters/Parameters.tsx

    parameters: ParameterModel[];
    onChange: (parameters: ParameterModel[]) => void;
-    onEditClick: (param: ParameterModel) => void;
+    onEditClick?: (param: ParameterModel) => void;


The onEditClick parameter has been made optional, but there's no documentation explaining when it should be provided versus when the inline editing should be used. Add a JSDoc comment explaining the two editing modes.

samithkavishke · 2026-02-13T02:29:27Z

workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/Forms/FTPForm/index.tsx

+                            <Divider />
+                            <AdvancedConfigsHeader onClick={() => setIsAdvancedConfigsExpanded(!isAdvancedConfigsExpanded)}>
+                                <Codicon name={isAdvancedConfigsExpanded ? "chevron-down" : "chevron-right"} sx={{ marginRight: 4 }} />
+                                <Typography variant="body2">Advanced Configs</Typography>


All the other places ex: Kafka we use Advanced Parameters name. Shall we change this into Advanced Parameters wdyt?

samithkavishke · 2026-02-13T05:52:03Z

workspaces/ballerina/ballerina-visualizer/src/views/BI/ServiceDesigner/index.tsx


    const haveServiceTypeName = serviceModel?.properties["serviceTypeName"]?.value;

+    const getFtpServiceTitle = () => {


This function determines the Main Panel's topic as well consider to use only on the side panel

niveathika added 4 commits February 12, 2026 12:23

Support multiple FTP services per listener

887cafb

Add FTP onError handler support

fe197d4

Add FTP post-process actions for success/error

dc4d78c

Design tweaks for define content schema flow

f9ac56d

niveathika requested a review from samithkavishke February 12, 2026 07:42

niveathika requested a review from Copilot February 12, 2026 07:43

Copilot started reviewing on behalf of niveathika February 12, 2026 07:44 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

samithkavishke reviewed Feb 13, 2026

View reviewed changes

kanushka changed the base branch from release/bi-1.7.x to release/bi-1.8.x February 17, 2026 03:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ftp improvements #1423

Add ftp improvements #1423
niveathika wants to merge 4 commits intowso2:release/bi-1.8.xfrom
niveathika:release/bi-1.7.x

niveathika commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

samithkavishke Feb 13, 2026

Uh oh!

samithkavishke Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const typeNameToParamName = (typeName: string, pluralize: boolean = false): string => {
	const convertTypeNameToParameterName = (typeName: string, pluralize: boolean = false): string => {


		const haveServiceTypeName = serviceModel?.properties["serviceTypeName"]?.value;

		const getFtpServiceTitle = () => {

Conversation

niveathika commented Feb 12, 2026

Purpose

Goals

Approach

UI Component Development

Manage Icons

User stories

Release note

Documentation

Training

Certification

Marketing

Automation tests

Security checks

Samples

Related PRs

Migrations (if applicable)

Test environment

Learning

Uh oh!

coderabbitai bot commented Feb 12, 2026

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

samithkavishke Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

samithkavishke Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants