-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the null pointer for operation json list. #406
base: master
Are you sure you want to change the base?
Conversation
|
||
//check if operationJsonList is null | ||
if (operationJsonList == null) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove new lines Line 759, 764
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by 14c2ca2
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9740839123
Purpose
Fix wso2/product-is#19409
This issue occures, when a invalid operation schema field given since it only accepts
Operations
field. Once json schema not contains this fieed correctly it will create a null pointer and raise an error in a for loop used to iterate that operation list.Goals
Handle the internal error in PATCH
scim2/v2/roles/{id}
API.Approach
operations
field and throws an bad request error with invalid json schema.operations
throws an bad request error with default error description.Security checks
Samples
Related PRs
wso2/docs-is#4395