-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Method to Retrieve User Roles of a Shared User #6308
Introduce Method to Retrieve User Roles of a Shared User #6308
Conversation
[Quality Gate failed] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6308 +/- ##
============================================
+ Coverage 45.91% 46.38% +0.47%
- Complexity 14481 14598 +117
============================================
Files 1672 1676 +4
Lines 103141 103109 -32
Branches 18010 18027 +17
============================================
+ Hits 47360 47832 +472
+ Misses 48970 48431 -539
- Partials 6811 6846 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
...ole.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java
Show resolved
Hide resolved
...ole.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java
Show resolved
Hide resolved
...role.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/SQLQueries.java
Show resolved
Hide resolved
[Quality Gate failed] |
After further evaluation, this functionality is no longer required as the intended use case is now being handled through alternative approaches within the system. As a result, this PR will be closed. Thank you to everyone who reviewed and contributed to this effort. |
Proposed changes in this pull request
getRoleIdListOfSharedUser
to fetch role IDs for shared users.getRoleIdListOfUser
to reuse common logic via a private method getRoleIdsOfUser.When should this PR be merged
Follow up actions
Related Issue
Introduce Method to Retrieve User Roles of a Shared User