Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when no actions configured. #6118

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

malithie
Copy link
Member

@malithie malithie commented Nov 8, 2024

Resolves wso2/product-is#21383

Proposed changes in this pull request

This PR fixes the case where an exception will thrown from ActionExecutionService when no actions are configured in the system.
So when no actions configured or if there's a failure in retrieving actions for the flow it will be considered as a scenario where no actions are applied. Thus, token issuance works as expected the state before.

Copy link

sonarcloud bot commented Nov 8, 2024

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.83%. Comparing base (4cdc52a) to head (2c4ccf5).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...tion/execution/impl/ActionExecutorServiceImpl.java 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6118   +/-   ##
=========================================
  Coverage     40.83%   40.83%           
+ Complexity    14500    14499    -1     
=========================================
  Files          1772     1772           
  Lines        117936   117936           
  Branches      19172    19172           
=========================================
+ Hits          48157    48160    +3     
+ Misses        62490    62488    -2     
+ Partials       7289     7288    -1     
Flag Coverage Δ
unit 25.07% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11749025346

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11749025346
Status: failure

@malithie
Copy link
Member Author

malithie commented Nov 9, 2024

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/11749025346 Status: failure

This failure is due to the fact that the version of the oauth component which is dependent on the framework components is not yet being updated in the product

@malithie malithie merged commit 6d5c76e into wso2:master Nov 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the access token flow to terminate for ERROR or FAILED action execution status
3 participants