-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managing custom federated authenticators. #6105
base: master
Are you sure you want to change the base?
Add support for managing custom federated authenticators. #6105
Conversation
6ce13a6
to
e887bdf
Compare
e887bdf
to
35805c7
Compare
a6d7a29
to
16268ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6105 +/- ##
============================================
- Coverage 40.94% 40.75% -0.20%
+ Complexity 14607 14569 -38
============================================
Files 1767 1775 +8
Lines 118050 118301 +251
Branches 19169 20420 +1251
============================================
- Hits 48339 48210 -129
- Misses 62426 62799 +373
- Partials 7285 7292 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c34802d
to
855a182
Compare
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 suggestion.
Files not reviewed (2)
- components/idp-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java: Evaluated as low risk
- components/idp-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/util/IdPManagementConstants.java: Evaluated as low risk
Comments skipped due to low confidence (1)
components/idp-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/util/AuthenticatorEndpointConfigurationManager.java:166
- The method should accept
AuthenticationType
as a parameter instead of hardcodingIDENTIFICATION
.
return new UserDefinedFederatedAuthenticatorConfig(AuthenticatorPropertyConstants.AuthenticationType.IDENTIFICATION);
...gt/src/main/java/org/wso2/carbon/idp/mgt/util/AuthenticatorEndpointConfigurationManager.java
Outdated
Show resolved
Hide resolved
4f4026e
to
e282f69
Compare
e282f69
to
8f5db0d
Compare
ddc6235
to
5a06202
Compare
dd8eed1
to
6ec6eb9
Compare
6ec6eb9
to
ad64f90
Compare
4b45336
to
75daff3
Compare
75daff3
to
2058f81
Compare
public UserDefinedAuthenticatorEndpointConfig(EndpointConfig endpointConfig) { | ||
|
||
this.endpointConfig = endpointConfig; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need this ? Then why we need a builder and have a private constructor ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this constructor introduced, we can create UserDefinedAuthenticatorEndpointConfig object just giving the endpoint object from action, like here https://github.com/wso2/carbon-identity-framework/pull/6105/files#diff-e15e35779957907ba8ea90f73d573eed6e57f3180c7412df385ec887597b20a7R128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the builder as well. Switch to one mode
08d0add
to
fe5a424
Compare
fe5a424
to
4261be4
Compare
...-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java
Show resolved
Hide resolved
b4a1bdf
to
ff5d911
Compare
...nt/src/main/java/org/wso2/carbon/identity/action/management/ActionManagementServiceImpl.java
Show resolved
Hide resolved
ff5d911
to
1d504b7
Compare
Quality Gate passedIssues Measures |
Issue:
With this PR, the IDP management service layer is enhanced to support custom federated authentication extensions.
The following changes are included:
API layer PR: