Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new client to call organization discovery configuration API #6099

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Nov 4, 2024

Proposed changes in this pull request

This PR adds a new client to call the organization discovery configuration API in order to retrieve the discovery configurations of a specific organization

When should this PR be merged

This should be merged after all prs of the below task is merged.

Related issue

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 40.61%. Comparing base (b777be3) to head (8d44d69).
Report is 190 commits behind head on master.

Files with missing lines Patch % Lines
...rganizationDiscoveryConfigDataRetrievalClient.java 77.77% 4 Missing and 2 partials ⚠️
...onDiscoveryConfigDataRetrievalClientException.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6099      +/-   ##
============================================
+ Coverage     40.27%   40.61%   +0.33%     
- Complexity    14430    14602     +172     
============================================
  Files          1760     1768       +8     
  Lines        119036   122277    +3241     
  Branches      21144    20533     -611     
============================================
+ Hits          47947    49665    +1718     
- Misses        63779    65233    +1454     
- Partials       7310     7379      +69     
Flag Coverage Δ
unit 25.00% <67.74%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


package org.wso2.carbon.identity.mgt.endpoint.util.client;

import org.apache.axis2.transport.http.HTTPConstants;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check for a different dependency for this. Within the framework ? Since we are planning to move away from axis2 in the future, we should try to minimize any usages for the new developments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was used only to import a authorization header constant. Can use a local constant instead. Updated with 8d44d69

Copy link

sonarcloud bot commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants