-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service layer support to manage the user defined local authenticators #6071
base: custom-local-auth-extensions
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java: Evaluated as low risk
- components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/model/VerificationAuthenticatorConfig.java: Evaluated as low risk
Comments skipped due to low confidence (2)
components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/constant/AuthenticatorMgtErrorConstants.java:40
- The error code '60004' is duplicated. It should be unique.
ERROR_BLANK_FIELD_VALUE("60004", "Invalid empty or blank value.",
components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/util/UserDefinedLocalAuthenticatorValidator.java:84
- The method validateDefinedByType references authenticatorConfig.getName(), but authenticatorConfig is not defined in the method scope. This will cause a compilation error.
String.format(error.getDescription(), authenticatorConfig.getName()));
Quality Gate failedFailed conditions |
Task issue:
With this PR following changes may introduced.
Related PRs:
Add DAO layer support to manage the user defined local authenticators #6070
Add unit tests for supporting manage the user defined local authenticators #6072