Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service layer support to manage the user defined local authenticators #6071

Open
wants to merge 4 commits into
base: custom-local-auth-extensions
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Oct 28, 2024

Task issue:

With this PR following changes may introduced.

  1. Introduce new VerificationAuthenticatorConfig class for 2FA authenticators extendingc LocalAuthenticatorConfig.
  2. Improve application authentication service to support managing new local custom authenticators (Local user account identification and 2FA authentication types)

Related PRs:

@Thisara-Welmilla Thisara-Welmilla changed the title Add new VerificationAuthenticatorConfig for verification authenticators Add service layer support to manage the user defined local authenticators Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java: Evaluated as low risk
  • components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/model/VerificationAuthenticatorConfig.java: Evaluated as low risk
Comments skipped due to low confidence (2)

components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/constant/AuthenticatorMgtErrorConstants.java:40

  • The error code '60004' is duplicated. It should be unique.
ERROR_BLANK_FIELD_VALUE("60004", "Invalid empty or blank value.",

components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/util/UserDefinedLocalAuthenticatorValidator.java:84

  • The method validateDefinedByType references authenticatorConfig.getName(), but authenticatorConfig is not defined in the method scope. This will cause a compilation error.
String.format(error.getDescription(), authenticatorConfig.getName()));
@Thisara-Welmilla Thisara-Welmilla marked this pull request as draft November 6, 2024 03:38
@Thisara-Welmilla Thisara-Welmilla marked this pull request as ready for review November 11, 2024 03:26
@Thisara-Welmilla Thisara-Welmilla changed the base branch from add-user-defined_authenticator_support to custom-local-auth-extensions November 11, 2024 03:28
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant