Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle client exceptions without logging #68

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Yoshani
Copy link
Contributor

@Yoshani Yoshani commented Nov 14, 2023

Proposed changes in this pull request

Currently we are logging all exceptions in the handler. Ideally we should not log client exceptions. This PR adds a separate method for handling client exceptions.

Related Issues

@Yoshani Yoshani requested a review from pulasthi7 November 14, 2023 06:42
@Yoshani Yoshani requested review from janakamarasena and removed request for janakamarasena November 14, 2023 06:42
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6860228213

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6860228213
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6860228213

@Yoshani Yoshani merged commit d1f3f55 into wso2-extensions:master Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants