Remove commonAuthId cookie if authentication flow failed

[hwupathum]

Summray

This pull request includes an important change to the OAuth2AuthzEndpoint class in the components/org.wso2.carbon.identity.oauth.endpoint package. The change ensures that the commonAuthId cookie is removed if the authentication flow fails.

Related issue

• AuthenticationResultCache expiry time is not honored  wso2/product-is#22194

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.18%. Comparing base (b21c233) to head (d2b68e8).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
...tity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2683      +/-   ##
============================================
- Coverage     56.18%   56.18%   -0.01%     
+ Complexity     8242     8233       -9     
============================================
  Files           631      631              
  Lines         46794    46802       +8     
  Branches       9043     9045       +2     
============================================
+ Hits          26291    26295       +4     
- Misses        16728    16730       +2     
- Partials       3775     3777       +2     

Flag	Coverage Δ
unit	38.74% <83.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hwupathum]

Decided not send this fix since this is an edge case