Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hybrid flow for configuring multiple hybrid flow response types #2677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thumimku
Copy link
Contributor

Proposed changes in this pull request

Issue: wso2/product-is#21140

HybridFlowConfigVideo.mp4
Screenshot 2025-01-18 at 18 45 43

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12844362203

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.56%. Comparing base (fad2923) to head (1b676f1).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...rg/wso2/carbon/identity/oauth/dao/OAuthAppDAO.java 83.33% 2 Missing and 1 partial ⚠️
...dentity/oauth/config/OAuthServerConfiguration.java 60.00% 1 Missing and 1 partial ⚠️
...lidators/AbstractResponseTypeRequestValidator.java 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2677      +/-   ##
============================================
+ Coverage     55.52%   55.56%   +0.03%     
- Complexity     8249     8316      +67     
============================================
  Files           632      632              
  Lines         48573    48658      +85     
  Branches       8934     8990      +56     
============================================
+ Hits          26970    27036      +66     
- Misses        17734    17760      +26     
+ Partials       3869     3862       -7     
Flag Coverage Δ
unit 39.03% <78.12%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12844362203
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12844362203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants