Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DCR PUT request not updating application role audience #2669

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Jan 9, 2025

This PR fixes an issue in the DCR PUT implementation where the application role audience value was not persisted to the database.

Changes

  • Added logic to store the application role audience during DCR updates.
  • Earlier if the client name is not is the request the SP is not updated, thats not correct, hence moving the update SP section outside the if block.
  • Improved unit tests to assert the application role audience update.

Issue

wso2/product-is#21627

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12686607755

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12686607755
Status: failure

@Thumimku Thumimku force-pushed the updateSPAudienceInDCR branch from c5d989a to 4a0382c Compare January 9, 2025 10:04
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12687705675

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.52%. Comparing base (fad2923) to head (4a0382c).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...carbon/identity/oauth/dcr/service/DCRMService.java 63.63% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2669   +/-   ##
=========================================
  Coverage     55.52%   55.52%           
  Complexity     8249     8249           
=========================================
  Files           632      632           
  Lines         48573    48572    -1     
  Branches       8934     8933    -1     
=========================================
  Hits          26970    26970           
+ Misses        17734    17732    -2     
- Partials       3869     3870    +1     
Flag Coverage Δ
unit 38.95% <63.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12687705675
Status: failure

@Thumimku
Copy link
Contributor Author

Thumimku commented Jan 9, 2025

Associated failure not related to this PR

@Thumimku Thumimku merged commit 7e302b5 into wso2-extensions:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants