Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the user attribute handling for implicit flow #2641

Conversation

indeewari
Copy link
Contributor

@indeewari indeewari commented Dec 4, 2024

Proposed changes in this pull request

Implementing the user attribute handling for implicit flow

When should this PR be merged

Once PR builder was successful

shashimalcse
shashimalcse previously approved these changes Dec 4, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12156915683

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12156915683
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12157887134

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.54%. Comparing base (b91c38d) to head (0a9904a).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...openidconnect/JWTAccessTokenOIDCClaimsHandler.java 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2641      +/-   ##
============================================
+ Coverage     56.46%   56.54%   +0.08%     
- Complexity     8196     8201       +5     
============================================
  Files           632      632              
  Lines         46331    46689     +358     
  Branches       8246     8353     +107     
============================================
+ Hits          26160    26400     +240     
- Misses        16453    16581     +128     
+ Partials       3718     3708      -10     
Flag Coverage Δ
unit 38.84% <75.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12157887134
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12164016068

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12164016068
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12164016068

sadilchamishka
sadilchamishka previously approved these changes Dec 4, 2024
@sadilchamishka sadilchamishka merged commit f9ec15d into wso2-extensions:master Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants