Exclude OIDC Session Management for Secondary Device in Device Grant Flow #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2639 +/- ##
============================================
- Coverage 56.44% 54.82% -1.62%
- Complexity 8193 8698 +505
============================================
Files 632 632
Lines 46331 51391 +5060
Branches 8246 9643 +1397
============================================
+ Hits 26151 28175 +2024
- Misses 16465 19163 +2698
- Partials 3715 4053 +338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
PR builder completed |
jenkins-is-staging
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12131667424
SujanSanjula96
force-pushed
the
device-code-fix
branch
from
f928a9a to
1f959e6
Compare
SujanSanjula96
force-pushed
the
device-code-fix
branch
from
0ccebd2 to
b072c24
Compare
|
Already fixed with #2109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
From this PR, OIDC Session Management is excluded for Secondary Device in Device Grant Flow. With that, NPE when getting session state param due to
nullcallback URL is fixed.Issue - wso2/product-is#16867