Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat the ID token signature validation failure as client error instead of generic error which will be logged as server error later #2628

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Treat the ID token signature validation failure as client error instead of generic error which will be logged as server error later #2628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ession/src/main/java/org/wso2/carbon/identity/oidc/session/servlet/OIDCLogoutServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,7 +1108,7 @@ private String getClientIdFromIdToken(HttpServletRequest request, String idToken
return OIDCSessionManagementUtil.extractClientIDFromDecryptedIDToken(decryptedIDToken);
} else {
if (!validateIdToken(idToken)) {
throw new IdentityOAuth2Exception(OAuth2ErrorCodes.OAuth2SubErrorCodes.INVALID_ID_TOKEN,
throw new IdentityOAuth2ClientException(OAuth2ErrorCodes.OAuth2SubErrorCodes.INVALID_ID_TOKEN,
"ID token signature validation failed.");
}
return extractClientFromIdToken(idToken);
Expand Down
Loading