Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding authentication methods display name for the client authenticators #2243

Merged

Conversation

ChinthakaJ98
Copy link
Contributor

Purpose

This PR updates the getSupportedClientAuthenticationMethods() method in the OAuthClientAuthenticator so that it could return both supported authentication mechanisms by the authenticator and their respective display names which could be displayed in the console UI.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6769241344

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6769241344
Status: failure

@ChinthakaJ98
Copy link
Contributor Author

Integration tests fail here because getSupportedClientAuthenticationMethods method [1] is updated in the OAuthClientAuthenticator interface and this needs to be updated in both MTLS and PrivateKey JWT authenticators as well. These authenticators has been updated accordingly in the PR [2].
[1] https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2243/files#diff-0b5655c78a741a01d6e1fac11bd4d3bf5b4da7a598fbd11c054b82bac6bcfe7aR76
[2] wso2-extensions/identity-oauth-addons#117

@janakamarasena janakamarasena merged commit ee96657 into wso2-extensions:master Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants