Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing TLS certificate based token binding type #2240

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Introducing TLS certificate based token binding type #2240

merged 10 commits into from
Nov 9, 2023

Conversation

ChinthakaJ98
Copy link
Contributor

Purpose

This PR includes the implementation to bind the hash of the TLS certificate passed in the request as the CNF value in the JWT access token token via a token binding type. With this implementation the CNF value can be obtained from the introspection as well for both JWT and Opaque access tokens. Also this PR includes changes to the discovery endpoint including tls_client_certificate_bound_access_tokens which is a FAPI requirement.

Related Issues

wso2/product-is#16518
wso2/product-is#16924

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6780880595

janakamarasena
janakamarasena previously approved these changes Nov 7, 2023
View reviewed changes
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6780880595
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6808246535

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6808246535
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 9, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6808246535

@janakamarasena janakamarasena merged commit d1ee8f8 into wso2-extensions:master Nov 9, 2023
@ChinthakaJ98 ChinthakaJ98 mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@janakamarasena janakamarasena janakamarasena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChinthakaJ98 @jenkins-is-staging @janakamarasena