Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client attestation proxy filter #2236

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Add client attestation proxy filter #2236

merged 10 commits into from
Nov 17, 2023

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Nov 1, 2023

Proposed changes in this pull request

Issue : wso2/product-is#16836

This interceptor, ClientAttestationProxy, is responsible for handling incoming JAX-RS messages related to client attestation. It checks for attestation information in the HTTP request and validates it to establish the client's authenticity and context.
It operates at the "PRE_INVOKE" phase, allowing it to access the message body and parameters.
The interceptor performs the following tasks:

  1. Extracts the HttpServletRequest from the incoming JAX-RS message.
  2. Retrieves the attestation header from the HTTP request.
  3. Extracts content parameters from the message.
  4. Validates attestation for API-based authentication requests.
  5. Sets the client attestation context in the HTTP request for further processing.

@Thumimku Thumimku force-pushed the clientAttestationProxy branch from 0ef6618 to a25a44e Compare November 2, 2023 06:38
@Thumimku Thumimku force-pushed the clientAttestationProxy branch from a25a44e to b9e8ef6 Compare November 10, 2023 10:55
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6824349643

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6824349643
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6845701889

@Thumimku
Copy link
Contributor Author

PR builder started Link: https://github.com/wso2/product-is/actions/runs/6845701889
[ERROR] Failures:
[ERROR] SelfRegisterTestCase.testSelfRegisterWithInvalidPassword:110 Self register user password invalid expected:<400> but was:<409>
[INFO]
[ERROR] Tests run: 2098, Failures: 1, Errors: 0, Skipped: 0

The failure is not related to the fix provided

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6845701889
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 13, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6845701889

@Thumimku Thumimku force-pushed the clientAttestationProxy branch from 70f0a58 to 8723b1d Compare November 14, 2023 05:16
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6859528548

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6859528548
Status: failure

@Thumimku Thumimku force-pushed the clientAttestationProxy branch from e39a075 to 967a18c Compare November 16, 2023 04:53
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6888191116

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6888191116
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 16, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6888191116

@Thumimku Thumimku force-pushed the clientAttestationProxy branch 2 times, most recently from 62c39ad to cc4844d Compare November 17, 2023 02:53
@Thumimku Thumimku force-pushed the clientAttestationProxy branch from 319c80d to e84d500 Compare November 17, 2023 03:19
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6899603932

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6899603932
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6900278615

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6900278615
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 17, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6900278615

@Thumimku Thumimku merged commit 233f262 into wso2-extensions:master Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@janakamarasena janakamarasena janakamarasena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thumimku @jenkins-is-staging @janakamarasena