Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dcr changes to add tls bound access token as a token binding type #2235

Merged
merged 15 commits into from
Nov 13, 2023
+82 −35
Merged

Make dcr changes to add tls bound access token as a token binding type #2235

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a533c97
make dcr changes to add tls bound access token as a token binding type
SachiniSiriwardene Nov 1, 2023
cb6c950
remove empty checks for update request
SachiniSiriwardene Nov 7, 2023
d441f2c
Merge branch 'master' of https://github.com/wso2-extensions/identity-…
SachiniSiriwardene Nov 7, 2023
7267f6d
remove empty checks for update request
SachiniSiriwardene Nov 8, 2023
1194345
Merge branch 'master' of https://github.com/wso2-extensions/identity-…
SachiniSiriwardene Nov 8, 2023
80f09ce
Merge branch 'master' of https://github.com/wso2-extensions/identity-…
SachiniSiriwardene Nov 9, 2023
28fa3f4
sync changes
SachiniSiriwardene Nov 9, 2023
dbe5ff2
sync changes
SachiniSiriwardene Nov 10, 2023
dec83f2
address pr comments
SachiniSiriwardene Nov 10, 2023
5d42e8b
add token binding service to dcr
SachiniSiriwardene Nov 10, 2023
17b0f6b
address pr comments
SachiniSiriwardene Nov 10, 2023
012b6f3
Merge branch 'master' of https://github.com/wso2-extensions/identity-…
SachiniSiriwardene Nov 10, 2023
9383bdc
remove deleted property from wsdl
SachiniSiriwardene Nov 13, 2023
258ed10
Merge branch 'master' of https://github.com/wso2-extensions/identity-…
SachiniSiriwardene Nov 13, 2023
1bed9a6
validate request object encryption values if not empty
SachiniSiriwardene Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sync changes
@SachiniSiriwardene
SachiniSiriwardene committed Nov 10, 2023
commit dbe5ff20d5d4b39db0330b6ffd7c37d500cb03c0
3 changes: 2 additions & 1 deletion ...ntity.oauth.dcr/src/main/java/org/wso2/carbon/identity/oauth/dcr/service/DCRMService.java
View file
Original file line number Diff line number Diff line change
@@ -633,7 +633,8 @@ private OAuthConsumerAppDTO createOAuthApp(ApplicationRegistrationRequest regist
oAuthConsumerApp.setRequirePushedAuthorizationRequests(
registrationRequest.isRequirePushedAuthorizationRequests());
if (registrationRequest.isTlsClientCertificateBoundAccessTokens()) {
if (Boolean.parseBoolean(IdentityUtil.getProperty(OAuthConstants.ENABLE_TLS_CERT_BOUND_ACCESS_TOKENS_VIA_BINDING_TYPE))) {
if (Boolean.parseBoolean(IdentityUtil.getProperty(
OAuthConstants.ENABLE_TLS_CERT_BOUND_ACCESS_TOKENS_VIA_BINDING_TYPE))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of checking for the config here lets check if the CERTIFICATE_BASED_TOKEN_BINDER component is available and then set it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

oAuthConsumerApp.setTokenBindingType(OAuth2Constants.TokenBinderType.CERTIFICATE_BASED_TOKEN_BINDER);
oAuthConsumerApp.setTokenBindingValidationEnabled(true);
}