-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to honour the locale for email notifications. #249
base: master
Are you sure you want to change the base?
Improvement to honour the locale for email notifications. #249
Conversation
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9868033876
9c3a092
to
3f6bff6
Compare
3f6bff6
to
92049ee
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
============================================
- Coverage 34.82% 34.64% -0.19%
Complexity 515 515
============================================
Files 74 74
Lines 4945 4942 -3
Branches 640 637 -3
============================================
- Hits 1722 1712 -10
- Misses 3058 3072 +14
+ Partials 165 158 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue:
Improvement to resolve locale attribute value of the authenticated user:
If a local user exists for the authenticated user, retrieve the locale value from the userStore. If no local user exists (either because it is the first time federated authentication or JIT provisioning is disabled), check the event properties for a local value, which will be set by the email authenticator step if there is a locale claim as an IDP claim. If neither of these conditions are met, set the default locale value.