Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODP-235] Allow private and hidden teams #537

Draft
wants to merge 20 commits into
base: dev
Choose a base branch
from
Draft

[ODP-235] Allow private and hidden teams #537

wants to merge 20 commits into from

Conversation

steveoni
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@steveoni steveoni requested a review from mpolidori September 29, 2024 08:09
Copy link
Collaborator

@mpolidori mpolidori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mpolidori
Copy link
Collaborator

@steveoni Also, the failing pipeline is not your code. I actually had this issue the other day. It was due to the trivy security scanner. It did get fixed, so I don't know why it's failing again here. Try pushing a dummy/empty commit to re-run whenever you get a chance.

@mpolidori mpolidori marked this pull request as draft September 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants