FLAG-866: fetch notifications and pass them as props to Header #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wri7tno
force-pushed
the
feat/FLAG-866--consume-notifications
branch
from
1f53d6f to
2df9dc0
Compare
wri7tno
force-pushed
the
feat/FLAG-866--consume-notifications
branch
from
2df9dc0 to
5ff1b15
Compare
willian-viana
approved these changes
Sep 7, 2023
| // eslint-disable-next-line no-undef | ||
| jest.mock('axios'); | ||
|
|
||
| describe('getPublishedNotifications', () => { |
| }, | ||
| ]; | ||
|
|
||
| axios.get.mockResolvedValueOnce(response); |
There was a problem hiding this comment.
What happened when the result is a empty array? Do you think we need to create a test for this case?
There was a problem hiding this comment.
not in this case since the empty array doesn't change anything, we are displaying a collection of items.
wri7tno
force-pushed
the
feat/FLAG-866--consume-notifications
branch
from
5ff1b15 to
ab47872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching notifications for all pages. Notifications aren't visible yet, that is going to be addressed in a separate ticket.
Overview
Brief description of what this PR does, and why it is needed.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing