Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLAG-876: Fix map legend circles being squished #4675

Merged
merged 1 commit into from
Sep 14, 2023
Merged

FLAG-876: Fix map legend circles being squished #4675

merged 1 commit into from
Sep 14, 2023

Conversation

SARodrigues
Copy link
Collaborator

@SARodrigues SARodrigues commented Aug 28, 2023 •
edited
Loading

Overview

The map legend's colored circles are being squished in some legend items, independently of the layer and/or legend in question.

It looks like this happens when the text next to the circle is too long, causing the circle's element to get squished. Setting a minWidth alongside the width seems to fix the issue.

Demo

circles_fixed

Notes

N/A

Testing

  1. Visit the corresponding JIRA task
  2. Review that the items/links in the description now work correctly

Tracking

https://gfw.atlassian.net/browse/FLAG-876

@SARodrigues SARodrigues self-assigned this Aug 28, 2023
@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4675 August 28, 2023 11:09 Inactive
@SARodrigues SARodrigues marked this pull request as ready for review August 28, 2023 11:20
@SARodrigues SARodrigues force-pushed the FLAG-876-the-shape-style-indicating-different-elements-within-the-layer-legend-is-off-for-several-datasets branch from 76095f4 to 829362f Compare September 6, 2023 09:28
@SARodrigues SARodrigues temporarily deployed to gfw-staging-pr-4675 September 6, 2023 09:28 Inactive
@SARodrigues SARodrigues requested a review from wri7tno September 6, 2023 09:31
@SARodrigues SARodrigues force-pushed the FLAG-876-the-shape-style-indicating-different-elements-within-the-layer-legend-is-off-for-several-datasets branch from 829362f to d6b498d Compare September 11, 2023 11:02
@SARodrigues SARodrigues temporarily deployed to gfw-staging-pr-4675 September 11, 2023 11:02 Inactive
@wri7tno
Copy link
Collaborator

wri7tno commented Sep 11, 2023

LGTM

willian-viana
willian-viana approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@willian-viana willian-viana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SARodrigues SARodrigues merged commit e6a16e7 into develop Sep 14, 2023
4 checks passed
@SARodrigues SARodrigues deleted the FLAG-876-the-shape-style-indicating-different-elements-within-the-layer-legend-is-off-for-several-datasets branch September 14, 2023 09:06
@SARodrigues SARodrigues mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wri7tno wri7tno wri7tno approved these changes

@willian-viana willian-viana willian-viana approved these changes

Assignees

@SARodrigues SARodrigues

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SARodrigues @wri7tno @willian-viana