feat(metadata): avoid merging null properties to metadata object

wri · Jul 2, 2024 · 0ba4cb4 · 0ba4cb4
1 parent 3924606
commit 0ba4cb4
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/pages/api/metadata/[...params].js b/pages/api/metadata/[...params].js
@@ -16,14 +16,25 @@ export default async (req, res) => {
       `${GFW_METADATA_API_URL}/dataset/gfw_integrated_alerts/v20240605/metadata`
     );
 
+    const dataVersionMetadataObject = datasetVersionMetadata.data.data;
+
     const response = {
       ...datasetMetadata.data.data,
       metadata: {
         ...datasetMetadata.data.data.metadata,
-        ...datasetVersionMetadata.data.data,
       },
     };
 
+    /*
+     * Merging the metadata from the second request
+     * avoiding overwrite the object properties with null value
+     */
+    Object.keys(dataVersionMetadataObject).forEach((key) => {
+      if (dataVersionMetadataObject[key] !== null) {
+        response.metadata[key] = dataVersionMetadataObject[key];
+      }
+    });
+
     return res.status(200).json(response);
   } catch (error) {
     if (error.response) {