Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› fix: GTC-3062 implementation replacement on redirect (#176) (#178) #181

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

gtempus
Copy link
Contributor

@gtempus gtempus commented Nov 26, 2024

  • πŸ› fix: Only replace implementation with dynamic
  • This PR only includes the redirect bug fix found during Natural Forest 2020 testing

Supports FLAG-1126

  • βœ… test: add initial pytest suite

  • 🎨 refactor: create more declarative methods and tests

  • πŸ“ docs: add docstring to handler

  • πŸ“ docs: add implementation note regarding relative URLs

(cherry picked from commit 8d79ee7)

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

* πŸ› fix: Only replace implementation with `dynamic`

Supports FLAG-1126

* βœ… test: add initial pytest suite

* 🎨 refactor: create more declarative methods and tests

* πŸ“ docs: add docstring to handler

* πŸ“ docs: add implementation note regarding relative URLs

(cherry picked from commit 8d79ee7)
(cherry picked from commit bc6a6c7)
@gtempus gtempus merged commit f9ab770 into production Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants