Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> staging: DIST alerts forest filter #171

Merged
merged 26 commits into from
Nov 7, 2024
Merged

Dev -> staging: DIST alerts forest filter #171

merged 26 commits into from
Nov 7, 2024

Conversation

solomon-negusse
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

…r endpoints consistent with tile cache service
…m for dist/integrated alerts as we surface in api doc
make titiler tile endpoints consistent with tile cache service
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.36508% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (4e9ba8d) to head (efab786).

Files with missing lines Patch % Lines
app/routes/titiler/umd_glad_dist_alerts.py 46.34% 22 Missing ⚠️
app/settings/globals.py 66.66% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #171      +/-   ##
===========================================
- Coverage    80.24%   79.85%   -0.40%     
===========================================
  Files           59       61       +2     
  Lines         1954     2050      +96     
===========================================
+ Hits          1568     1637      +69     
- Misses         386      413      +27     
Flag Coverage Δ
unittests 79.85% <79.36%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@solomon-negusse solomon-negusse merged commit bd534de into staging Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants