Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging -> production: DIST alerts with forest filters and encoded tiles titiler support #168

Closed
wants to merge 69 commits into from

Conversation

solomon-negusse
Copy link
Member

@solomon-negusse solomon-negusse commented Oct 23, 2024

No description provided.

@solomon-negusse solomon-negusse changed the title Staging -> production dist alerts and encoded tiles titiler support staging -> production: DIST alerts and encoded tiles titiler support Oct 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.97674% with 28 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (1fd53c6) to head (d894a17).
Report is 1 commits behind head on production.

Files with missing lines Patch % Lines
app/routes/titiler/umd_glad_dist_alerts.py 47.61% 22 Missing ⚠️
app/settings/globals.py 66.66% 4 Missing ⚠️
app/routes/titiler/algorithms/alerts.py 97.29% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           production     #168      +/-   ##
==============================================
+ Coverage       79.76%   79.86%   +0.09%     
==============================================
  Files              57       61       +4     
  Lines            1898     2051     +153     
==============================================
+ Hits             1514     1638     +124     
- Misses            384      413      +29     
Flag Coverage Δ
unittests 79.86% <86.97%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dmannarino
dmannarino previously approved these changes Oct 24, 2024
Copy link
Member

@dmannarino dmannarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet refactor! Thanks for all the documentation, tests!

@solomon-negusse solomon-negusse changed the title staging -> production: DIST alerts and encoded tiles titiler support staging -> production: DIST alerts with forest filters and encoded tiles titiler support Nov 7, 2024
danscales
danscales previously approved these changes Nov 8, 2024
Copy link
Contributor

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Though I'm not totally sure if we need to push the dist alerts changes to production yet. Did you want to wait a bit and see if we have any more bug fixes or adjustments to endpoints, etc.? Whatever you think is best is fine.

solomon-negusse and others added 16 commits November 11, 2024 21:41
fix tree cover loss year field type; update var name to make mypy happy
consistent and descriptive forest filter query params; detailed decod…
* 🐛 fix: Only replace implementation with `dynamic`

Supports FLAG-1126

* ✅ test: add initial pytest suite

* 🎨 refactor: create more declarative methods and tests

* 📝 docs: add docstring to handler

* 📝 docs: add implementation note regarding relative URLs
* 🐛 fix: Only replace implementation with `dynamic`

Supports FLAG-1126

* ✅ test: add initial pytest suite

* 🎨 refactor: create more declarative methods and tests

* 📝 docs: add docstring to handler

* 📝 docs: add implementation note regarding relative URLs

(cherry picked from commit 8d79ee7)
switch from lambda to titiler tiling for integrated alerts
We are hitting the edges of the whole-world bounding box for very north
tiles, and need to add some rounding to deal with slight imprecision in
the floating point computations.
Fix "Tile index out of bounds" error for very north tiles
@danscales
Copy link
Contributor

Not needed, I merged the dist alert changes separately.

@danscales danscales closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants