GTC-2663: Merge Dev into Staging #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#130) * feat(include attributes): get the fields from Data API * refactor: use aenum to store the aggregation rule close to the enum * refactor(SupportedAttributes): rename formal parameter to mention aggregation Attributes enum from nasa_viirs was not appropriate for the generic vector tile endpoint * refactor: delete nasa viirs fire alerts attributes enum No longer used. SupportedAttributes enum is now used. * refactor(data_api): make call to Data API async * test: disable a few tests that require some refactoring work before they are valuable again. * refactor(tile cache assets): remove `fields` from the SQL query. We moved fields into the `field_metadata` table in the GTC-1347 Metadata epic: https://gfw.atlassian.net/browse/GTC-1347 Keeping it in the query only causes confusion. * refactor: remove unused `get_attributes` function * refactor(Attributes): tile cache type is no longer needed. * refactor(DataAPI): DRY up the two functions to remove duplication * docs: Minor update to `include_attributes` * fix(sync_db): ensure rows returned from tile cache query is iterable
dmannarino
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#130)
feat(include attributes): get the fields from Data API
refactor: use aenum to store the aggregation rule close to the enum
refactor(SupportedAttributes): rename formal parameter to mention aggregation
Attributes enum from nasa_viirs was not appropriate for the generic vector tile endpoint
No longer used. SupportedAttributes enum is now used.
refactor(data_api): make call to Data API async
test: disable a few tests that require some refactoring work before they are valuable again.
refactor(tile cache assets): remove
fieldsfrom the SQL query.We moved fields into the
field_metadatatable in the GTC-1347 Metadata epic: https://gfw.atlassian.net/browse/GTC-1347Keeping it in the query only causes confusion.
refactor: remove unused
get_attributesfunctionrefactor(Attributes): tile cache type is no longer needed.
refactor(DataAPI): DRY up the two functions to remove duplication
docs: Minor update to
include_attributesfix(sync_db): ensure rows returned from tile cache query is iterable