Develop to master #183
Merged
Develop to master #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datapump was using the lambda-layer module of the gfw-lambda-layers repo. This module only updates a lambda layer if the associated Dockerfile changes, since it is mainly targeted to creating layers of existing python libraries, so only the version number in the Dockerfile matters. So, changed the terraform to build the layer.zip using the usual Dockerfile, but using the hash of the entire layer.zip to decide if the layer.zip should be uploaded to S3 and used to update the lambda. We no longer use the lambda-layer module. The layer.zip file includes all the modified times of the files, which keep changing, even when the file names and contents are the same. I tried generating a hash using only filenames and contents, but terraform seems to create its own hash of the layer.zip file as well, so basically we're always going to update the layer.zip no matter what, which seems fine. Added a bunch of explanatory comments, cleaned up some other comments.
GTC-1250 Update lambda layer based on any datapump source changes
solomon-negusse
approved these changes
Feb 25, 2025
danscales
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information