Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge up GTC-2977 DIST-Alerts to master #165

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Merge up GTC-2977 DIST-Alerts to master #165

merged 17 commits into from
Nov 25, 2024

Conversation

manukala6
Copy link
Member

@manukala6 manukala6 commented Nov 25, 2024 •
edited by jira bot
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: GTC-2977

What is the new behavior?

  • DIST-Alerts

Does this introduce a breaking change?

  • Yes
  • No

Other information

manukala6 and others added 15 commits November 4, 2024 11:19
@manukala6 manukala6 requested review from danscales, solomon-negusse and dmannarino and removed request for danscales November 25, 2024 19:10
danscales
danscales approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danscales
Merge pull request #164 from wri/run-dist
cf9a875 
Schedule DIST-alerts sync for 1pm PST every day on production
@manukala6 manukala6 merged commit e251cb0 into master Nov 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danscales danscales danscales approved these changes

@solomon-negusse solomon-negusse Awaiting requested review from solomon-negusse

@dmannarino dmannarino Awaiting requested review from dmannarino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manukala6 @danscales