Only sync past day of subscriptions instead of default 2 days to avoid timeout

[jterry64]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
• Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
• Check the commit's or even all commits' message styles matches our requested structure.
• Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

The call to /area/sync is timing out every night. Without date parameter, it defaults to syncing 2 days of subscriptions.

Issue Number: N/A

What is the new behavior?

Only sync one day of subscriptions to reduce chance of timeout.

Does this introduce a breaking change?

• Yes
• No

Other information

[danscales]

I think you said that the API syncs two days by default? But in the RW docs it says it does the last week by default ( https://resource-watch.github.io/doc-api/reference.html#sync-areas ) If it really does one week by default, I wonder if you could try maybe two or three days for syncing (rather than one), just to be more likely that no areas slip through the cracks (in case datapump somehow doesn't run one night)?

[jterry64]

I think you said that the API syncs two days by default? But in the RW docs it says it does the last week by default ( https://resource-watch.github.io/doc-api/reference.html#sync-areas ) If it really does one week by default, I wonder if you could try maybe two or three days for syncing (rather than one), just to be more likely that no areas slip through the cracks (in case datapump somehow doesn't run one night)?

If you remember from the last huddle, even though it says a week, @solomon-negusse showed us the code actually defaults to two days: https://github.com/gfw-api/gfw-area/blob/fe2ba0b314a91eb320893591a69b7a44f3dd993f/app/src/routes/api/v2/area.router.js#L632