Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge up fires, lambda layer changes #151

Merged
merged 8 commits into from
Aug 28, 2024
Merged

Merge up fires, lambda layer changes #151

merged 8 commits into from
Aug 28, 2024

Conversation

dmannarino
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dmannarino dmannarino changed the title Merge up fires, lambda layer changes Don't merge until Tuesday night: Merge up fires, lambda layer changes Aug 20, 2024
Copy link
Contributor

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. But just wondering - if you are able to confirm that the old layers are not changed, then you don't actually have to check this in tonight, right? That would be one less moving part, if you are definite that the old layers haven't changed. Then you could check it in later after other things are confirmed to be working.

@dmannarino
Copy link
Member Author

Seems fine. But just wondering - if you are able to confirm that the old layers are not changed, then you don't actually have to check this in tonight, right? That would be one less moving part, if you are definite that the old layers haven't changed. Then you could check it in later after other things are confirmed to be working.

Good point!

@dmannarino dmannarino changed the title Don't merge until Tuesday night: Merge up fires, lambda layer changes Merge up fires, lambda layer changes Aug 21, 2024
@dmannarino dmannarino merged commit 70d0aef into master Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants