Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cif 293 set tile size in meters for fishnet functions #89

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Cif 293 set tile size in meters for fishnet functions #89

merged 6 commits into from
Nov 5, 2024

Conversation

kcartier-wri
Copy link
Contributor

Tested locally and through integration testing on EC2s. In addition to the test code, I have examined and measured the results in QGIS

@kcartier-wri kcartier-wri requested a review from chrowe November 4, 2024 21:36
chrowe
chrowe approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@chrowe chrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to follow all the changes but generally looks good to me and works for me locally. It looks like the tile size is roughly what I set but not exactly and it is slightly different for each tile.

@kcartier-wri kcartier-wri marked this pull request as ready for review November 5, 2024 00:09
@kcartier-wri kcartier-wri merged commit 845ec8a into main Nov 5, 2024
1 check passed
@kcartier-wri kcartier-wri deleted the CIF-293-Set-tile-size-in-meters-for-fishnet-functions branch November 5, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrowe chrowe chrowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcartier-wri @chrowe