Use hub long option names and use named release uploads. See [Issue #…

…112](#112).
wpsharks · Dec 21, 2016 · 315ff0c · 315ff0c
1 parent 355d769
commit 315ff0c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/psr4/targets/releases/lite-release-finish.xml b/src/psr4/targets/releases/lite-release-finish.xml
@@ -77,10 +77,10 @@
         <available resource="${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.phar" type="file" />
       </and>
       <then>
-        <property name="_releases_lite_release_git_create_assets" value="--asset '${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.zip#${project_lite_slug}-v${project_version}.zip' --asset '${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.tar.gz#${project_lite_slug}-v${project_version}.tar.gz' --asset '${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.phar#${project_lite_slug}-v${project_version}.phar'" />
+        <property name="_releases_lite_release_git_create_assets" value="--asset='${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.zip#${project_lite_slug}-v${project_version}.zip' --asset='${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.tar.gz#${project_lite_slug}-v${project_version}.tar.gz' --asset='${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.phar#${project_lite_slug}-v${project_version}.phar'" />
       </then>
       <else>
-        <property name="_releases_lite_release_git_create_assets" value="--asset '${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.zip#${project_lite_slug}-v${project_version}.zip' --asset '${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.tar.gz#${project_lite_slug}-v${project_version}.tar.gz'" />
+        <property name="_releases_lite_release_git_create_assets" value="--asset='${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.zip#${project_lite_slug}-v${project_version}.zip' --asset='${project.basedir}/.~build/${project_lite_slug}/.~build/${project_lite_slug}.tar.gz#${project_lite_slug}-v${project_version}.tar.gz'" />
       </else>
     </if>
 
@@ -158,7 +158,7 @@
       </else>
     </if>
 
-    <property name="_releases_lite_release_git_create_command" value="hub release create -f '${_tmp_sub_dir}/${project_lite_slug}-commit-msg'${_releases_lite_release_git_create_pre}${_releases_lite_release_git_create_draft} ${_releases_lite_release_git_create_assets} ${project_version}" />
+    <property name="_releases_lite_release_git_create_command" value="hub release create --file='${_tmp_sub_dir}/${project_lite_slug}-commit-msg'${_releases_lite_release_git_create_pre}${_releases_lite_release_git_create_draft} ${_releases_lite_release_git_create_assets} ${project_version}" />
     <exec command="${_releases_lite_release_git_create_command}" dir="${_releases_lite_release_repo_dir}" checkReturn="true" outputProperty="_releases_lite_release_git_create_output" />
 
     <property name="_releases_lite_release_git_create_release_url" value="${_releases_lite_release_git_create_output}">

diff --git a/src/psr4/targets/releases/release-finish.xml b/src/psr4/targets/releases/release-finish.xml
@@ -184,10 +184,10 @@
         <available resource="${project.basedir}/.~build/${project_slug}.phar" type="file" />
       </and>
       <then>
-        <property name="_releases_release_git_create_assets" value="--asset '${project.basedir}/.~build/${project_slug}.zip#${project_slug}-v${project_version}.zip' --asset '${project.basedir}/.~build/${project_slug}.tar.gz#${project_slug}-v${project_version}.tar.gz' --asset '${project.basedir}/.~build/${project_slug}.phar#${project_slug}-v${project_version}.phar'" />
+        <property name="_releases_release_git_create_assets" value="--asset='${project.basedir}/.~build/${project_slug}.zip#${project_slug}-v${project_version}.zip' --asset='${project.basedir}/.~build/${project_slug}.tar.gz#${project_slug}-v${project_version}.tar.gz' --asset='${project.basedir}/.~build/${project_slug}.phar#${project_slug}-v${project_version}.phar'" />
       </then>
       <else>
-        <property name="_releases_release_git_create_assets" value="--asset '${project.basedir}/.~build/${project_slug}.zip#${project_slug}-v${project_version}.zip' --asset '${project.basedir}/.~build/${project_slug}.tar.gz#${project_slug}-v${project_version}.tar.gz'" />
+        <property name="_releases_release_git_create_assets" value="--asset='${project.basedir}/.~build/${project_slug}.zip#${project_slug}-v${project_version}.zip' --asset='${project.basedir}/.~build/${project_slug}.tar.gz#${project_slug}-v${project_version}.tar.gz'" />
       </else>
     </if>
 
@@ -273,7 +273,7 @@
       </else>
     </if>
 
-    <property name="_releases_release_git_create_command" value="hub release create --file '${_tmp_sub_dir}/${project_slug}-commit-msg'${_releases_release_git_create_pre}${_releases_release_git_create_draft} ${_releases_release_git_create_assets} ${project_version}" />
+    <property name="_releases_release_git_create_command" value="hub release create --file='${_tmp_sub_dir}/${project_slug}-commit-msg'${_releases_release_git_create_pre}${_releases_release_git_create_draft} ${_releases_release_git_create_assets} ${project_version}" />
     <exec command="${_releases_release_git_create_command}" dir="${project.basedir}" checkReturn="true" outputProperty="_releases_release_git_create_output" />
 
     <property name="_releases_release_git_create_release_url" value="${_releases_release_git_create_output}">