Set DependentLoadFlags on shared windows binaries #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThadHouse
force-pushed
the
dependentloadflags
branch
from
3112b71
to
38f9710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DependentLoadFlags is something added in Windows 10 RS1 that allows modules to specify how they load their dll dependencies. By default, the application path, system32, and some other paths are searched. However, for our use this is kind of a pain, as when we extract libraries, they're not in the same path as the executable.
This PR adds the LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR flag, which lets us specify to load from our own dll directory first.