Add a user agent and use requests error checking #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
reviewed
Nov 21, 2024
| @@ -62,14 +63,13 @@ def read_file(self, url, location=None): | |||
| # try: | |||
| # with codecs.open(url, 'r', self.encoding, errors='strict') as f: # type: ignore # NOQA | |||
| # text = f.read() # type: unicode | |||
| response = requests.get(url) | |||
| response = requests.get( | |||
| url, headers={"User-Agent": "sphinxext-remoteliteralinclude"} | |||
There was a problem hiding this comment.
Generally you're supposed to put a version here too.
There was a problem hiding this comment.
My copy and paste python skills failed me trying to get the version from setup.py from perusing stackexchange using importlib
There was a problem hiding this comment.
User agents for bots are a mess anyway, trying to evade blocks. If it works, it works
TheTripleV
approved these changes
Nov 21, 2024
sciencewhiz
force-pushed
the
UserAgent
branch
from
0205ecd
to
0ceb233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.