-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-file overrides using field lists #50
Conversation
…page overrides and in general will only happen when it becomes a html tag and starts mattering.
Probably should be done at this point, but it really does seem like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. It is much needed. I didn't notice it was marked as ready till now, sorry!
The PR seems fine logic wise, there's just a few changes I want to increase readability of the code.
Regarding the names of the fields, do field lists support underscores? If so, I think using underscores instead of hyphens would be better as the variable names in conf.py and the names of the field list keys would match. Also, since making this extension support all opengraph tags would be nice. So, transforming all field list entries of the form |
Regarding the underscores for names, I think it's supported but field lists everywhere else use hyphens, so I think it'd be better to be consistent with that. |
Co-authored-by: Dalton Smith <[email protected]>
Note, relative image paths in the custom overrides are broken (intentionally) in this PR. A fix should be included as a part of #53. |
Use field lists to implement per page overrides
Closes #11.
It seems like
__init__.py
might be due for a slight rewrite after this change.